additional magnum importer plugins in python build dependencies #2105
Conversation
facebook-github-bot
added
the
CLA Signed
src/cmake/dependencies.cmake
Outdated
| @@ -357,7 +357,6 @@ if(NOT USE_SYSTEM_MAGNUM) | |||
| MagnumPlugins::AssimpImporter | |||
| MagnumPlugins::BasisImporter | |||
| MagnumPlugins::GltfImporter | |||
| MagnumPlugins::StanfordImporter | |||
There was a problem hiding this comment.
remove StanfordImporter as it doesn't support ASCII ply.
Ah, that's one of my TODOs. I'm not interested in implementing parsing of ASCII PLY files myself, but it could delegate to Assimp for those.
Where do these come from, btw? Is there some Habitat code that writes them? Might be a candidate for refactor / replacement with builtin Magnum PLY export functionality.
What StanfordImporter can do and Assimp can't is import of files with per-vertex semantic IDs. I remember that used to be used quite often, not sure if that's still relevant for current datasets.
There was a problem hiding this comment.
Thanks for the thoughts on this topic.
I don't think semantic ids in .ply are necessary for python import, but ASCII ply is an easy format for hand-edited or human-readable mesh data. Agreed we generally don't try to use these in practice.
Motivation and Context
Python importer used in Habitat-lab requires linked Magnum plugins from Habitat=sim.
How Has This Been Tested
NA
Types of changes
Checklist